Conversation
|
Sorry @HansH111, I see no justification for merging this in the main code and adding yet another function call to the C stack of every ksh process in existence, for the benefit of (as far as I know) one person. There's no one else who can use it since whatever is interfacing with your patch is not available to the rest of us. I think what you want would be better achieved with separate C program that links against libshell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended sh_main to sh_mainex by adding extra parameters in function to support loading ksh code from a memory location.
added functions sh_main and sh_maincode to support original and memory kshcode to use sh_mainex.
removed error message when SHOPT SCRIPTONLY=1 because it breaks embedded usage.